Match end of suffix against .sql and .sql.jinja #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
tconbeer
requested changes
Jan 17, 2023
There was a problem hiding this comment.
We need to add a test for this new behavior. You can modify this test:
sqlfmt/tests/unit_tests/test_api.py
Line 32 in dda6f07
You'll have to add a file in the directory referenced in that test, maybe tests/data/unit_tests/test_api/test_file_discovery/a_directory/two.file.sql or similar.
We also need to add an item to CHANGELOG.md.
Once you have that done, I can add a commit to get the primer check to pass. Or if you prefer (let me know), I can just take it from here.
Thanks for contributing!
|
I've added the requested changes and the test and updated the changelog. |
tconbeer
approved these changes
Jan 17, 2023
|
Thanks again for contributing, @ysmilda! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #354
This allows to use the CLI against files which are named
.{something}.sqland.{something}.sql.jinja.I'll be the first to admit that I know nothing about python as a language, so there might be a better way of doing this. But it passes the tests and explains my issues goal.