Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

union distinct shouldn't have distinct on a different line #417

Closed
tconbeer opened this issue May 5, 2023 Discussed in #416 · 0 comments · Fixed by #420
Closed

union distinct shouldn't have distinct on a different line #417

tconbeer opened this issue May 5, 2023 Discussed in #416 · 0 comments · Fixed by #420
Labels
bug Something isn't working style for issues that change the sqlfmt style

Comments

@tconbeer
Copy link
Owner

tconbeer commented May 5, 2023

Discussed in #416

Originally posted by paschmaria May 4, 2023
Describe the bug
distinct shouldn't be on the next line for union distinct

To Reproduce

select *
from table_a
union distinct
select *
from table_b

Expected behavior

select *
from table_a
union distinct
select *
from table_b

Actual behavior

select *
from table_a
union
distinct
select *
from table_b

Additional context

What is the output of sqlfmt --version?

sqlfmt, version 0.18.1
@tconbeer tconbeer added bug Something isn't working style for issues that change the sqlfmt style labels May 5, 2023
tconbeer added a commit that referenced this issue May 10, 2023
@tconbeer
fix #417: parse union distinct correctly
6e9615c
@tconbeer tconbeer linked a pull request May 10, 2023 that will close this issue
fix #417: parse union distinct correctly #420
Merged
tconbeer added a commit that referenced this issue May 10, 2023
@tconbeer
fix #417: parse union distinct correctly (#420)
b50aec9 
* fix #417: parse union distinct correctly

* chore: bump primer refs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working style for issues that change the sqlfmt style
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #417: parse union distinct correctly tconbeer/sqlfmt
1 participant
@tconbeer