Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokenize output for equivalence check #328

Closed
tconbeer opened this issue Nov 29, 2022 · 0 comments · Fixed by #349
Closed

Tokenize output for equivalence check #328

tconbeer opened this issue Nov 29, 2022 · 0 comments · Fixed by #349
Labels
enhancement New feature or request
Milestone
v0.15.0

Comments

@tconbeer
Copy link
Owner

Black parses input and output code unless you use --fast as an extra safety check. I've been wanting to do this, but thought I was blocked by the lack of a good sql parser.

A much simpler option is to just lex the output, and make sure that the tokens are the same as those from the input (except for newlines and other gotchas tbd).
@tconbeer tconbeer added the enhancement New feature or request label Nov 29, 2022
@tconbeer tconbeer added this to the v0.15.0 milestone Nov 30, 2022
tconbeer added a commit that referenced this issue Jan 6, 2023
@tconbeer
feat: add safety check, close #328
a8c042d
@tconbeer tconbeer mentioned this issue Jan 6, 2023
Merged
tconbeer added a commit that referenced this issue Jan 6, 2023
@tconbeer
feat: add safety check, close #328 (#349)
e207ea6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

Lex output for safety check tconbeer/sqlfmt
1 participant
@tconbeer