Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add docs for adapter.connection_id #94

Merged
merged 1 commit into from
Aug 16, 2024
Merged

fix: add docs for adapter.connection_id #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: add docs for adapter.connection_id
  • Loading branch information
@tconbeer
tconbeer committed Aug 16, 2024
commit 8f79bc9d7f6a7b5735d0dadf65a9f5a239bfd235
2 changes: 2 additions & 0 deletions src/docs/contributing/adapter-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ The first is the `HarlequinAdapter`, which is initialized with `conn_str` (a tup

The primary purpose of an adapter is to provide its `connect()` method, which creates and returns an instance of `HarlequinConnection`.

Optionally, adapters may implement a `connection_id` property that uniquely identifies the connection in a manner that is stable between Harlequin invocations. Harlequin uses this `connection_id` to persist and retrieve the data catalog and query history across invocations of Harlequin.

### HarlequinConnection

A connection must provide two methods: `get_catalog` and `execute`.
Expand Down