Normative: Don't call well-known Symbol methods for RegExp on primitive values
#3009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
normative change
|
@petamoriken can someone from deno add this to the March meeting agenda? |
|
@lucacasonato Would you work on this issue? |
petamoriken
force-pushed
the
normative/dont-call-regexp-@@method-on-primitives
branch
from
ca31671 to
25424af
Compare
|
I can see that this change would cause this to no longer evaluate to “surprise”: String.prototype[Symbol.split] = () => "surprise";
"a.b.c".split(".");I see no obvious downside to the proposed change in a vacuum, but given it’s a breaking change, I’m curious whether there’s been research yet on whether it’s web compatible in practice? (It seems plausible that it could be safe, but it also seems plausible that faithful polyfill implementations, e.g. @zloirock’s core-js, could be impacted). |
|
|
petamoriken
force-pushed
the
normative/dont-call-regexp-@@method-on-primitives
branch
from
25424af to
5942961
Compare
petamoriken
force-pushed
the
normative/dont-call-regexp-@@method-on-primitives
branch
from
5942961 to
f9d3b02
Compare
petamoriken
force-pushed
the
normative/dont-call-regexp-@@method-on-primitives
branch
from
f9d3b02 to
c45ae45
Compare
petamoriken
changed the title
RegExp on primitive valuesRegExp on primitive values
|
The const isObject = v => Object(v) === v; |
petamoriken
force-pushed
the
normative/dont-call-regexp-@@method-on-primitives
branch
from
c45ae45 to
9b254aa
Compare
petamoriken
force-pushed
the
normative/dont-call-regexp-@@method-on-primitives
branch
from
9b254aa to
cd6e94f
Compare
nicolo-ribaudo
added
has consensus
|
Test262 PR has landed. |
ptomato
added
has test262 tests
and removed
needs test262 tests
sosukesuzuki
added a commit
to sosukesuzuki/WebKit
that referenced
this pull request
Mar 29, 2025
https://bugs.webkit.org/show_bug.cgi?id=290684 Reviewed by NOBODY (OOPS!). This patch implements tc39/ecma262#3009. test262 has been updated for it already[1]. [1]: tc39/test262@abc22b5 * JSTests/test262/expectations.yaml: * Source/JavaScriptCore/builtins/StringPrototype.js: (match): (matchAll): (intrinsic.StringPrototypeReplaceIntrinsic.replace): (intrinsic.StringPrototypeReplaceAllIntrinsic.replaceAll): (search): (split):
sosukesuzuki
added a commit
to sosukesuzuki/WebKit
that referenced
this pull request
Mar 29, 2025
https://bugs.webkit.org/show_bug.cgi?id=290684 Reviewed by NOBODY (OOPS!). This patch implements tc39/ecma262#3009. test262 has been updated for it already[1]. [1]: tc39/test262@abc22b5 * JSTests/test262/expectations.yaml: * Source/JavaScriptCore/builtins/StringPrototype.js: (match): (matchAll): (intrinsic.StringPrototypeReplaceIntrinsic.replace): (intrinsic.StringPrototypeReplaceAllIntrinsic.replaceAll): (search): (split):
webkit-commit-queue
pushed a commit
to sosukesuzuki/WebKit
that referenced
this pull request
Mar 30, 2025
https://bugs.webkit.org/show_bug.cgi?id=290684 Reviewed by Yusuke Suzuki. This patch implements tc39/ecma262#3009. test262 has been updated for it already[1]. [1]: tc39/test262@abc22b5 * JSTests/test262/expectations.yaml: * Source/JavaScriptCore/builtins/StringPrototype.js: (match): (matchAll): (intrinsic.StringPrototypeReplaceIntrinsic.replace): (intrinsic.StringPrototypeReplaceAllIntrinsic.replaceAll): (search): (split): Canonical link: https://commits.webkit.org/292913@main
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 25, 2025
… on primitives r=dminor,iain This patch adds telemetry for tc39/ecma262#3009. That normative PR has already been approved by TC39, but we need to verify that it's web compatible. Differential Revision: https://phabricator.services.mozilla.com/D241305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed that methods for
RegExp, such as@@split, are not called on primitive values.Background
The internal code of runtimes such as Node.js and Deno are implemented that they work without problems even if they are polluted with prototypes. With this normative change in place, those runtimes don't need to worry if changes to
String.prototype[Symbol.split]are polluted.On the other hand, if this normative change is not approved, the following workaround will have to be provided:
This approach could cause performance issue.
downstream: denoland/deno#17473