Migrate from objc/cocoa to objc2
#150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
approved these changes
Sep 8, 2024
Member
|
Thank you |
amrbashir
approved these changes
Sep 8, 2024
94 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tauri-apps/wry#1239 and backreferences to madsmtm/objc2#174 for context and details.
I decided to keep the
NSVisualEffectMaterialandNSVisualEffectStatedefinitions that this crate re-exports, since they're public API, and I didn't want to tie the public API toobjc2-app-kit's. Besides,objc2-app-kithas to use a newtype for soundness, while this crate can more easily use anenum.