Skip to content

Conversation

@bradphelan
Copy link
Contributor

This shows issue #506 failing

@tsung-wei-huang
Copy link
Member

I am looking into that. thanks!

@tsung-wei-huang
Copy link
Member

@bradphelan The problem happens because tf::Semaphore or tf::CriticalSection is not thread-safe. In your case, multiple subflows will try to add their tasks into the critical section. Does this make sense?

Copy link

@CodeHarbour-Genie CodeHarbour-Genie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review for unittests/test_semaphores.cpp:
Additions: 122
Deletions: 78
AI Genie analysis: <generator object Client._stream at 0x000002007453AF00>

Copy link

@CodeHarbour-Genie CodeHarbour-Genie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review for unittests/test_semaphores.cpp:
Additions: 122
Deletions: 78
AI Genie analysis: <generator object Client._stream at 0x000001E5B5A72F00>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants