Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Pull Policy to Latest Images #461

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

phutelmyer
Copy link
Contributor

@phutelmyer phutelmyer commented Jun 12, 2024

Changes

Summary

This pull request adds the pull_policy: always option to ensure that Docker Compose always pulls the latest images for the following services:

  • frontend (./build/docker-compose-no-build.yaml)
  • backend (./build/docker-compose-no-build.yaml)
  • ui (./build/docker-compose.yaml and ./build/docker-compose-no-build.yaml)

Note: This change requires Docker Compose version 3.7 or later.

Issues Fixed

Previously, if a user had an older image in their repository, docker would start up the preexisting image, even if it wasn't necessarily the latest image in the remote repository.

Motivation and Context

To ensure that the latest versions of the images are always used, reducing the risk of running outdated versions.

Testing

Testing Configurations

  • Docker Compose version: 3.7+
  • Services tested: frontend, backend, ui

Steps to Reproduce

  1. Update Docker Compose file to include pull_policy: always.
  2. Run docker-compose pull to pull the latest images.
  3. Run docker-compose up -d to start the services.
  4. Verify that the latest images are being used by inspecting the running containers.

Sample Output

N/A - This change does not modify the output of Strelka.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@phutelmyer phutelmyer requested a review from skalupa June 12, 2024 17:54
@phutelmyer phutelmyer added the enhancement New feature or request label Jun 12, 2024
@phutelmyer phutelmyer merged commit 91f51e6 into master Jun 13, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant