Skip to content

ui: resolve yarn warnings #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 30, 2021
Merged

ui: resolve yarn warnings #2041

merged 4 commits into from
Nov 30, 2021

Conversation

dctalbot
Copy link
Contributor

@dctalbot dctalbot commented Nov 23, 2021

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR resolves a number of warnings given in the npm package install including:

  • remove babel-eslint in favor of @typescript-eslint/parser
  • standard 16.0.0 and eslint-config-standard 16.0.0 no longer require the eslint-plugin-standard package. You can remove it. More info here: Eliminate eslint-plugin-standard standard/standard#1316
  • [email protected]: This package has been renamed to "react-countdown".
  • @types/[email protected]: This is a stub types definition. classnames provides its own type definitions, so you do not need this installed.

This will help with maintenance and decrease the number of security warnings we get from stale packages.

Review guide:

  • first, checkout branch and run yarn
  • make sure yarn run lint works
  • make sure yarn workspaces run check works
  • make sure the countdown on alert details works (X seconds until next escalation)

@dctalbot dctalbot changed the title resolve yarn warnings ui: resolve yarn warnings Nov 23, 2021
@dctalbot dctalbot marked this pull request as ready for review November 23, 2021 20:47
@dctalbot dctalbot merged commit 1a1bf2b into master Nov 30, 2021
@dctalbot dctalbot deleted the dep-fixes branch November 30, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants