Skip to content

Properly extract classes with arbitrary values in arrays and classes followed by escaped quotes #6590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thecrypticace merged 23 commits into from
Dec 17, 2021
Merged

Properly extract classes with arbitrary values in arrays and classes followed by escaped quotes #6590

thecrypticace merged 23 commits into from
Dec 17, 2021
+142 −23

Conversation

@thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Dec 17, 2021

This should now properly extract classes with arbitrary values when in an array and also when they occur at the end of a string with escaped quotes.

Basically these all work now:

["text-[10px]", "lg:text-[14px]"]
['text-[10px]', 'lg:text-[14px]']
[`text-[10px]`, `lg:text-[14px]`]
{"code": "<div class=\"text-sm lg:text-lg\">"}

@thecrypticace thecrypticace changed the title Pull default extractor into separate file Properly extract classes with arbitrary values in arrays and classes followed by escaped quotes Dec 17, 2021
@thecrypticace thecrypticace merged commit 27c67fe into master Dec 17, 2021
@thecrypticace thecrypticace deleted the fix/extractor branch December 17, 2021 15:15
This was referenced Dec 17, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thecrypticace @RobinMalfait