Skip to content

Add css functions to data types #6258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RobinMalfait merged 4 commits into from
Dec 3, 2021
Merged

Add css functions to data types #6258

RobinMalfait merged 4 commits into from
Dec 3, 2021

Conversation

@RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented Dec 3, 2021 •
edited
Loading

This PR adds min, max and clamp as css functions to data types.
This allows us to also write more "modern" arbitrary values, e.g.:

<div class="text-[min(10vh,100px)]"></div>

Which results in:

.text-\[min\(10vh\2c 100px\)\] {
  font-size: min(10vh, 100px);
}

Before this PR, this code wouldn't even be generated, if you wanted this to be generated then you had to force the length: data type for example:

<div class="text-[length:min(10vh,100px)]"></div>

@RobinMalfait RobinMalfait merged commit 078186a into master Dec 3, 2021
@RobinMalfait RobinMalfait deleted the add-length-data-type-functions branch December 3, 2021 17:15
@dcastil dcastil mentioned this pull request Dec 10, 2021
Merged
45 tasks
@ben-rogerson ben-rogerson mentioned this pull request Dec 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RobinMalfait