Skip to content

Remove menu element styles #6213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RobinMalfait merged 2 commits into from
Nov 29, 2021
Merged

Remove menu element styles #6213

RobinMalfait merged 2 commits into from
Nov 29, 2021

Conversation

@AviAvinav
Copy link
Contributor

@AviAvinav AviAvinav commented Nov 28, 2021 •
edited
Loading

Removed the default spacing and set list-style-type to none for the menu element.

To fix issue: #6191

P.S. - This is my first pull request so please forgive any mistakes.

@adamwathan
Copy link
Member

adamwathan commented Nov 28, 2021

Hey thanks! I think this should be menu not main right? Let's just add it to the list here since the reset is for the same purpose:

https://github.com/tailwindlabs/tailwindcss/blob/master/src/css/preflight.css#L290-L295

@AviAvinav
Copy link
Contributor Author

AviAvinav commented Nov 29, 2021 •
edited
Loading

Oops! Sorry, my bad, will fix it.

@AviAvinav AviAvinav changed the title Remove main element styles Remove menu element styles Nov 29, 2021
@AviAvinav
Copy link
Contributor Author

AviAvinav commented Nov 29, 2021

Hey thanks! I think this should be menu not main right? Let's just add it to the list here since the reset is for the same purpose:

https://github.com/tailwindlabs/tailwindcss/blob/master/src/css/preflight.css#L290-L295

Thanks for pointing it out. Fixed it.

@RobinMalfait RobinMalfait merged commit f267d91 into tailwindlabs:master Nov 29, 2021
@RobinMalfait
Copy link
Member

RobinMalfait commented Nov 29, 2021

Hey! Thank you for your PR!
Much appreciated! 🙏

@dcastil dcastil mentioned this pull request Dec 10, 2021
Merged
45 tasks
@ben-rogerson ben-rogerson mentioned this pull request Dec 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AviAvinav @adamwathan @RobinMalfait