Ensure [hidden] works as expected #4873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I have said this before and say it again. AWESOME project. I love it. I'm a customer xD Ok let's go to my issue 😅 Is this the expected behavior? So I see I can fix on my part easily like this: .hidden-attribute[hidden] {
@apply hidden;
}But I love Tailwind and I hate write CSS |
|
I guess this could be a variant like this? const FancyReactComponent = ({ hidden }) => {
return (<div className="flex:not([hidden])" hidden={hidden}>I'm hidden now</div>
}I know I could do this with CSS classes. But in my use case I don't control the React component, just the CSS so the react component use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4872.
This PR makes sure that the expected behavior of the
[hidden]attribute is preserved even on elements where we override the defaultdisplayvalue, like images, videos, iframes, etc.