Register dark mode plugin outside of resolveConfig code path #2368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @adamwathan, thank you for the really quick fix! Keep up the good work, highly appreciate your dedication to tailwind 😁 Now, a quick question from my side, wouldn't it be better to have the |
Member
Author
|
Yeah I totally agree but we’d need to figure an API for that, can’t just magically exist you know? Can definitely add a CLI command that spits it out. We use babel-preval ourselves when we need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2354.
This isn't a long-term solution but will make things less annoying for people for now. Basically the problem is if we aren't careful, we introduce dependencies into
resolveConfigthat aren't compatible with the browser. We should probably tackle this as a dedicated project some point and come up with an overall better solution to the whole problem of trying to access your config in JS. Personally I don't think people actually want this code in their client bundles, they just want the resolved config. Something likeprevalis probably the way to go here, but I don't know how we bake that into Tailwind itself.