Improve font stack with standard font families #1711
Closed
+73
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe |
Contributor
Author
|
Good catch, that should definitely be included as well 😄. Will add it later today. |
Contributor
Author
It's actually So I've now added |
Member
|
Merged manually to resolve conflicts, not sure why GitHub doesn't pick it up :/ 2c6f237 Thanks! |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This change extends the current font stack for both sans-serif and serif with new "standard font families". Please see: https://www.w3.org/TR/css-fonts-4/#ui-serif-def
For the default font and
font-sansclass/variants this won't have much effect for now, sincesystem-uiand-apple-systemare already included. Forfont-serifandfont-monoit now includesui-serif/ui-monospace, for which support from Safari landed just last month with Safari 13.1.To summarize the change:
ui-sans-serif, which makes it:ui-serif, which makes it:ui-monospace, which makes it:Thanks and keep up the good work! Tailwind CSS is awesome 🚀