Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most 64-bit Linux systems and macOS use LP64 with 64-bit
long
and pointers. Windows is slightly different and uses LLP64.This means that on LP64 systems
long
andlong long
are the same size.As usual cppreference.com has a good page on Fundamental Types.
The current definition of the
byteSwap
functions useunsigned short
,unsigned int
andunsigned long long
for 16-, 32-, and 64-bit uints.The definitions I've seen for the various builtin
bswap
functions are defined using fixed with types. For example gcc has the folllwing:And macOS uses something similar for the
OSSwap
functions.I think it would be great if TagLib followed suit.