Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shell] Support multi-vterm in spacemacs/projectile-shell #16734

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

sunlin7
Copy link
Contributor

@sunlin7 sunlin7 commented Dec 18, 2024

To support the multi-vterm in projectile.
Enable the shell layer with multi-vterm, then open a projectile directory (eg: ~/.emacs.d/), then try SPC p $ to call spacemacs/projectile-shell, which does not work with multi-vterm.

(shell :variables shell-default-shell 'multi-vterm)

The PR will support the multi-vterm for projectile.

@bcc32 bcc32 changed the title * layers/+tools/shell/funcs.el: New function to support [shell] Support multi-vterm in spacemacs/projectile-shell Dec 18, 2024
layers/+tools/shell/funcs.el Outdated Show resolved Hide resolved
layers/+tools/shell/funcs.el Outdated Show resolved Hide resolved
layers/+tools/shell/funcs.el Outdated Show resolved Hide resolved
@sunlin7 sunlin7 force-pushed the multi-vterm-for-projectile branch from 9894f06 to b446a0d Compare December 18, 2024 05:12
@sunlin7
Copy link
Contributor Author

sunlin7 commented Dec 18, 2024

@bcc32 I had push the latest changes, please help review again. Thanks

@bcc32 bcc32 self-requested a review December 18, 2024 07:05
@bcc32
Copy link
Collaborator

bcc32 commented Dec 18, 2024

@sunlin7 please see if the latest version works for you

@sunlin7
Copy link
Contributor Author

sunlin7 commented Dec 18, 2024

@bcc32 it works for me. Thank you.

@bcc32 bcc32 merged commit c186b86 into syl20bnr:develop Dec 18, 2024
7 of 9 checks passed
Bost pushed a commit to Bost/spacemacs that referenced this pull request Dec 21, 2024
…6734)

* * layers/+tools/shell/funcs.el: New function to support

* Hide internal function from M-x

---------

Co-authored-by: Aaron L. Zeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants