-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #49
Update README.md #49
Conversation
Added exception handling notice starting docker image.
Hi @iDschepe , weird as that's what I thought the So therefore, the way I now understand it is: docker run --rm -p 8000:8000 surrealdb/surrealdb:latest start will download the image if it doesn't exist and: docker run --pull --rm -p 8000:8000 surrealdb/surrealdb:latest start will update the image if it does exist but isn't the latest, but won't pull it initially if it doesn't exist? Is this correct? |
Hi @tobiemh, I agree, it is a bit confusing. Yes, it is exactly like you wrote. The very first time I used the command, I got the error mentioned in the PR.
AND it is starting up just fine, output:
|
wording
Ok in that case, instead of adding the 'if you experience an error' section, could we change the initial command to just docker run --rm -p 8000:8000 surrealdb/surrealdb:latest start and then add a section below it to 'update the image to the latest version': docker pull surrealdb/surrealdb That way, the first command should always succeed! |
Changed initial command and added section to update docker image on demand.
Updated the PR as you suggested. Thanks! |
Thanks @iDschepe for this commit 😀👏! And thanks for your input @sunero4! |
Alright! I will prepare soon.
Tobie Morgan Hitchcock ***@***.***> schrieb am Di. 23. Aug.
2022 um 09:25:
… Ok this case, instead of adding the 'if you experience an error' section,
could we change the initial command to just
docker run --rm -p 8000:8000 surrealdb/surrealdb:latest start
and then add a section below it to 'update the image to the latest
version':
docker pull surrealdb/surrealdb
That way, the first command should always succeed!
—
Reply to this email directly, view it on GitHub
<#49 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJVLKA6T7C75SXWTLNNOYILV2R4F7ANCNFSM57KBBHGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
What is the motivation?
Allow people to start the docker image. Improve documentation.
What does this change do?
Added exception handling notice starting docker image at readme.