Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #49

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Update README.md #49

merged 3 commits into from
Aug 23, 2022

Conversation

iDschepe
Copy link
Contributor

What is the motivation?

Allow people to start the docker image. Improve documentation.

What does this change do?

Added exception handling notice starting docker image at readme.

Added exception handling notice starting docker image.
@tobiemh
Copy link
Member

tobiemh commented Aug 23, 2022

Hi @iDschepe , weird as that's what I thought the --pull argument did!

So therefore, the way I now understand it is:

docker run --rm -p 8000:8000 surrealdb/surrealdb:latest start

will download the image if it doesn't exist and:

docker run --pull --rm -p 8000:8000 surrealdb/surrealdb:latest start

will update the image if it does exist but isn't the latest, but won't pull it initially if it doesn't exist?

Is this correct?

@iDschepe
Copy link
Contributor Author

Hi @tobiemh, I agree, it is a bit confusing.

Yes, it is exactly like you wrote.

The very first time I used the command, I got the error mentioned in the PR.
So, I tried to delete the image and all containers and re-run your new command (without --pull option):

docker run --rm -p 8000:8000 surrealdb/surrealdb:latest start

AND it is starting up just fine, output:

Unable to find image 'surrealdb/surrealdb:latest' locally
latest: Pulling from surrealdb/surrealdb
...

@tobiemh
Copy link
Member

tobiemh commented Aug 23, 2022

Ok in that case, instead of adding the 'if you experience an error' section, could we change the initial command to just

docker run --rm -p 8000:8000 surrealdb/surrealdb:latest start

and then add a section below it to 'update the image to the latest version':

docker pull surrealdb/surrealdb

That way, the first command should always succeed!

@tobiemh tobiemh mentioned this pull request Aug 23, 2022
2 tasks
Changed initial command and added section to update docker image on demand.
@iDschepe
Copy link
Contributor Author

Updated the PR as you suggested. Thanks!

@tobiemh tobiemh merged commit 201406b into surrealdb:main Aug 23, 2022
@tobiemh
Copy link
Member

tobiemh commented Aug 23, 2022

Thanks @iDschepe for this commit 😀👏! And thanks for your input @sunero4!

@iDschepe iDschepe deleted the patch-1 branch August 23, 2022 09:03
@iDschepe
Copy link
Contributor Author

iDschepe commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants