Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move is::* -> string::is::*, add new type::is::* fncs #2603

Merged
merged 12 commits into from
Sep 4, 2023
Merged

move is::* -> string::is::*, add new type::is::* fncs #2603

merged 12 commits into from
Sep 4, 2023

Conversation

kearfy
Copy link
Member

@kearfy kearfy commented Sep 4, 2023 •
edited by tobiemh
Loading

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What is the motivation?

  • With the foresight of being able to use string functions in idiom paths, we want to move them to the string:: scope.
  • We want to add new type checking functions

What does this change do?

It implements both changes described above

What is your testing strategy?

Moved/updated/added tests

Is this related to any issues?

Closes #204.
Closes #2302.

Have you read the Contributing Guidelines?

@kearfy kearfy marked this pull request as ready for review September 4, 2023 12:25
@kearfy kearfy requested review from a team September 4, 2023 12:25
@kearfy kearfy requested review from a team and tobiemh as code owners September 4, 2023 12:25
@tobiemh tobiemh added this to the v1.0.0-beta.11 milestone Sep 4, 2023
@kearfy kearfy force-pushed the micha/move-around-is-functions branch from 5c596b6 to 82d54df Compare September 4, 2023 12:28
This was referenced Sep 4, 2023
Closed
Closed
@kearfy kearfy force-pushed the micha/move-around-is-functions branch from 82d54df to 330ede9 Compare September 4, 2023 12:39
@kearfy
Copy link
Member Author

kearfy commented Sep 4, 2023

Half of the github runners seem to be broken 😅

DelSkayn
DelSkayn previously approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@DelSkayn DelSkayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

DelSkayn
DelSkayn previously approved these changes Sep 4, 2023
View reviewed changes
@tobiemh tobiemh added this pull request to the merge queue Sep 4, 2023
Merged via the queue into main with commit 22c36b8 Sep 4, 2023
18 checks passed
@tobiemh tobiemh deleted the micha/move-around-is-functions branch September 4, 2023 16:30
@leefordjudes leefordjudes mentioned this pull request Oct 1, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiemh tobiemh tobiemh approved these changes

@DelSkayn DelSkayn DelSkayn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0-beta.11
Development

Successfully merging this pull request may close these issues.

Bug: Math function should ignore non numeric values when applied as aggregation function. Bug: Undefined attribute in a record is considered during query
3 participants
@kearfy @tobiemh @DelSkayn