Fix icon paths on markdown files #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, icons were not properly loading due to path error.
finnbear
reviewed
May 18, 2023
finnbear
reviewed
May 18, 2023
finnbear
reviewed
May 18, 2023
finnbear
suggested changes
May 18, 2023
There was a problem hiding this comment.
Thanks for your efforts to improve the markdown icons. I'm curious what browser and browser version you are using because, when I look at the markdown in Firefox or Chromium, I see all the icons.
Also, I left some comments on things that were changed beyond simply correcting icon paths.
|
@finnbear I used Google chrome (113.0.5672.126), safari (16.4) and GitHub Android app (1.113.1). I did not see any icons or illustrations. I can also preview a Markdown file in Visual Studio Code, and icons were not showing. Btw I'm from India, I don't know if that matters! |
finnbear
approved these changes
May 19, 2023
|
@finnbear after adding the |
tobiemh
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
What is the motivation?
Prior to this commit, icons were not properly loading due to path error.
What does this change do?
Changes icon path and comment out not-used icons in markdown files
What is your testing strategy?
It's only a change in icon path in markdown files
Is this related to any issues?
I did not check if there's any issue regarding this!
Have you read the Contributing Guidelines?