-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: partial enable s3 and tmp file system #429
feat: partial enable s3 and tmp file system #429
Conversation
7c37f32
to
187af32
Compare
357b461
to
52af82d
Compare
@@ -87,7 +87,12 @@ where | |||
|
|||
// use a dummy npm registry url | |||
let npm_registry_url = ModuleSpecifier::parse("https://localhost/").unwrap(); | |||
let root_path = std::env::temp_dir().join(format!("sb-compile-{}", current_exe_name)); | |||
let root_path = if cfg!(target_family = "unix") { | |||
PathBuf::from("/var/tmp") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does it need to be /var/tmp
instead of /tmp
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was changed because if the contents of eszip binary is mounted under /tmp
, it will conflict with tmpfs and become inaccessible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah gotcha!
🎉 This PR is included in version 1.61.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What kind of change does this PR introduce?
Feature, Enhancement
Description
This PR implements s3 file system and tmp file system.
Access to them is supported via some of the Deno APIs below.
To access each filesystem, the path must be preceded by a prefix.
Below are the prefixes required to access the file system.
Note that for the s3 file system, the path segment that appears right after
/s3
is treated as a bucket name.Below is a snippet with a detailed description of the s3 path.
The following is a sample code snippet that attempts to access the file system in the import statement.
Note that accessing the file system in this way is not currently allowed (but may be reconsidered in the future).
You can also pass configurations for these file systems in the main worker script.