-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support specifying npm registries via .npmrc #427
feat: support specifying npm registries via .npmrc #427
Conversation
604925e
to
f4ba3b6
Compare
773727e
to
baba456
Compare
862f128
to
fb36a4a
Compare
Thanks @nyannyacha 🎉 |
I apologize for the delay.😅 The other work is taking longer than I expected, so I decided to prioritize this. |
No need for apologies at all! |
🎉 This PR is included in version 1.59.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
@elyobo is this working for you on local? I'm running v.1.65.3 but still getting:
|
@israpasos thanks for reminding me to revisit this; I had to backport some changes that I'd make locally for the specific private package code that I'd just copied in as a workaround, but after getting them sorted I have... ran into a very similar sounding issue.
I'm running the most recent
|
Hello @israpasos and @elyobo 😁 I think that problem is not a problem with the edge runtime itself, but a problem caused by cli. I have confirmed that if you place If you have time, please open this issue with @supabase/cli. btw, if you guys are commenting on a closed PR, I will not be able to respond quickly to your comments, so please create a new issue next time 🤗 |
Thanks @nyannyacha, I'll check this out this afternoon and open an issue with |
@elyobo Thank you! |
@nyannyacha I've confirmed what you said above, it works if a valid I'll open a |
What kind of change does this PR introduce?
Feature
Description
Add support for importing packages from the private npm registry via
.npmrc
.Also, the packages imported from these registries are added together during the bundling process, so it shouldn't change existing behavior.
Resolves #402