Skip to content
This repository has been archived by the owner on Mar 6, 2018. It is now read-only.

Small changes #1

Merged
merged 5 commits into from
Apr 17, 2016
Merged

Small changes #1

merged 5 commits into from
Apr 17, 2016

Conversation

delba
Copy link
Collaborator

@delba delba commented Apr 17, 2016

Hi Luke,

I never would have dreamt that a lib would be created on top on Permission 😍😍
Thank you so much!!!

I tried to give back a bit with this PR ;)


// MARK: - Permission

private extension Permission: AssociatedObject {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't use private with protocol conformances 😢 I'd say we just move private to functions below?

@sunshinejr
Copy link
Owner

sunshinejr commented Apr 17, 2016

Hey Damien! 🎉

First of all thanks for your kind words! I really love Permission, you did great job on that! 💯 As for pull request, it seems also really nice, thank you! I've made some comments but that shouldn't be a problem 🐼

@delba
Copy link
Collaborator Author

delba commented Apr 17, 2016

😱 Sorry for all the errors, I coded without the compiler...
I rebased the PR, it should be fine now ;)

BTW do you plan to support Carthage ?

@sunshinejr
Copy link
Owner

No worries 🐼 It looks perfect now, thanks again! About Carthage, of course, just I'm not that experienced with Cathage so wanted to do it later, but if you have any experience, I would be more than happy to see a PR from you :)

@sunshinejr sunshinejr merged commit 7a36fea into sunshinejr:master Apr 17, 2016
@sunshinejr
Copy link
Owner

I've also added you as a collaborator to this project, if you don't mind 🎉

@delba
Copy link
Collaborator Author

delba commented Apr 17, 2016

Ahah great thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants