Avoid XfrmPolicyList return nil data.#2122
Closed
yanggangtony wants to merge 1 commit intosubmariner-io:develfrom
yanggangtony:code-clean
Closed
Avoid XfrmPolicyList return nil data.#2122yanggangtony wants to merge 1 commit intosubmariner-io:develfrom yanggangtony:code-clean
yanggangtony wants to merge 1 commit intosubmariner-io:develfrom
yanggangtony:code-clean
Conversation
yanggangtony
requested review from
Oats87,
skitt,
sridhargaddam and
tpantelis
as code owners
Contributor
|
🤖 Created branch: z_pr2122/yanggangtony/code-clean |
Signed-off-by: yanggang <[email protected]>
skitt
requested changes
Nov 14, 2022
Member
skitt
left a comment
skitt
left a comment
There was a problem hiding this comment.
This isn’t necessary, (*IPNet).String() handles nil references correctly. Dst or Src being nil won’t cause a panic.
Contributor
Author
@skitt |
Contributor
|
🤖 Closed branches: [z_pr2122/yanggangtony/code-clean] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yanggang [email protected]
Avoid xfrmPolicyList interface return nil data to crash the golang.