[DOC] Improve the hostname verification docs for NodePort listeners #10880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <[email protected]>
scholzj
changed the title
PaulRMellor
approved these changes
Nov 26, 2024
Contributor
PaulRMellor
left a comment
PaulRMellor
left a comment
There was a problem hiding this comment.
Thanks for the update. I left a couple of suggestions around wording.
documentation/modules/deploying/con-hostname-verification-node-ports.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/deploying/con-hostname-verification-node-ports.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: PaulRMellor <[email protected]> Signed-off-by: Jakub Scholz <[email protected]>
scholzj
deleted the
docs-improve-the-node-port-hostname-verification-docs
branch
OwenCorrigan76
pushed a commit
to OwenCorrigan76/strimzi-kafka-operator
that referenced
this pull request
Dec 6, 2024
…trimzi#10880) Signed-off-by: Jakub Scholz <[email protected]> Co-authored-by: PaulRMellor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR improves the docs for the TLS hostname verification when using Node Port listener and suggests that one of the alternatives in situations when users know the broker addresses upfront (e.g. on bare-metal with dedicated nodes) is to add the addressed manually to
alternativeNames.Checklist