Adding initial Hetzner Cloud provider #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason when an object isn't found in hcloud-go nil is returned but err is also nil. So I have to check if the object is nil and create the err myself.
|
It occurred to me that I already had access to the target name so it made no sense to ask for a name attribute in the config. Oopsie. |
stephank
approved these changes
Mar 11, 2021
|
You're welcome. This is a really neat project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds initial Hetzner Cloud provider. It's mostly referenced by the AWS EC2 provider but adapted to HCloud SDK.
In Hetzner Cloud a server name is required and unique (at least per project, which is the scope of the API token). The server gets a random numeric ID but it's not used anywhere in UI to identify the server, so I thought instead it would be better to choose a name prefix and then a random string appended to it for the ID.