fix(webpack-model): remove modules size duplication in foam-tree #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smelukov please take a look. Should not take much time |
smelukov
reviewed
Mar 9, 2024
| @@ -145,12 +145,6 @@ export default function modulesToFoamTree( | |||
|
|
|||
| for (const module of modules) { | |||
| handleModule(root, module, getModuleSize); | |||
|
|
|||
| if (module.modules) { | |||
There was a problem hiding this comment.
This will hide all inner modules of concat modules
The better solution is to ignore root concat module size for calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All modules already presented in root
modulesfield ofstats.json. Further more nomodule.modulesfield found in webpack documentationWebpack bundle analyzer handle duplication issue with module.id check for already handled but i think we can safely drop inner modules traversing at all