Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TypeScript to 5.7.2 #5128

Merged
merged 9 commits into from
Nov 29, 2024
Merged

Update TypeScript to 5.7.2 #5128

merged 9 commits into from
Nov 29, 2024

Conversation

davidkpiano
Copy link
Member

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 52d9cdd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Andarist
Andarist reviewed Nov 28, 2024
View reviewed changes
packages/xstate-react/test/useActor.test.tsx Outdated
@@ -815,7 +815,7 @@ describeEachReactMode('useActor (%s)', ({ suiteKey, render }) => {
return (
<>
<ChildTest send={send} />
{state.value}
{state.value as string}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need those casts out of a sudden?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS now complains that state.value can be an invalid child, which is true - it technically can be an object here, which is not allowed anymore I suppose.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use setup here to avoid those casts :) b798338

@davidkpiano davidkpiano merged commit 9d44c90 into main Nov 29, 2024
1 check passed
@davidkpiano davidkpiano deleted the davidkpiano/ts-5.7.2 branch November 29, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andarist Andarist Andarist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidkpiano @Andarist