[@xstate/store] Compatibility with @xstate/react's useSelector(…) hook
#4844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e5b4d41 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
reviewed
Apr 10, 2024
| @@ -10,10 +10,15 @@ function defaultCompare<T>(a: T, b: T) { | |||
| return a === b; | |||
| } | |||
|
|
|||
| export function useSelector<TActor extends AnyActorRef | undefined, T>( | |||
| export function useSelector< | |||
| TActor extends Pick<AnyActorRef, 'subscribe' | 'getSnapshot'> | undefined, | |||
There was a problem hiding this comment.
why is the previous version not compatible?
There was a problem hiding this comment.
Because Store is not fully compatible with AnyActorRef.
I tried this without this change and TypeScript complained about it
There was a problem hiding this comment.
Hm, ok - lots of things are missing from this. The solution is OK 👍 I would do the same in all of the other integration packages though. @xstate/react shouldn't be the only one that becomes compatible with this
Andarist
reviewed
Apr 11, 2024
Andarist
approved these changes
Apr 16, 2024
Co-authored-by: Mateusz Burzyński <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.