Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Remove some typegen-specific types #4600

Merged
merged 9 commits into from
Dec 23, 2023
Merged

[core] Remove some typegen-specific types #4600

merged 9 commits into from
Dec 23, 2023

Conversation

davidkpiano
Copy link
Member

Motivation:

  • The preferred way of avoiding missing implementations is to use setup(...).createMachine(...)
  • Specialized type-checking should be via a language server (e.g. in a future extension) or something like eslint
  • Desire to simplify the types in XState and integrations

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: bd080b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@xstate/svelte Patch
@xstate/react Patch
@xstate/vue Patch
xstate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Dec 17, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bd080b9:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@Andarist
Copy link
Member

The preferred way of avoiding missing implementations is to use setup(...).createMachine(...)

It's just that this one isn't the case yet. setup isn't fully capable of avoiding missing implementations.

@davidkpiano
Copy link
Member Author

@Andarist Is this good to go?

@Andarist
Copy link
Member

I'm working on some further code cleanups related to this.

Andarist
Andarist reviewed Dec 23, 2023
View reviewed changes
packages/xstate-solid/test/useMachine.test.tsx
isAwesome: () => isAwesome()
}
});
const [state, send] = useMachine(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in a separate PR we should remove some of the tests here - we have 2 describe blocks here, one is targeting the strict mode... but Solid doesn't have strict mode. Those tests were just copy-pasted from @xstate/react and didn't go through a purge of redundancy :P

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@Andarist Andarist merged commit 1f2ccb9 into main Dec 23, 2023
2 checks passed
@Andarist Andarist deleted the davidkpiano/remove-typegen-code branch December 23, 2023 19:01
@github-actions github-actions bot mentioned this pull request Dec 23, 2023
Merged
@Andarist Andarist mentioned this pull request Jan 11, 2024
Merged
This was referenced Jan 18, 2024
Open
Open
@abdulrahman305 abdulrahman305 mentioned this pull request Jan 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andarist Andarist Andarist left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidkpiano @Andarist