Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xstate-svelte: Avoid using svelte store get in useSelector. #3603

Merged
merged 4 commits into from
Nov 14, 2022
Merged

xstate-svelte: Avoid using svelte store get in useSelector. #3603

merged 4 commits into from
Nov 14, 2022

Conversation

mittinatten
Copy link
Contributor

The Svelte docs say get should not be used in hot paths. It is used in useSelector to compare the updated value with the previous value. This PR changes the function to store the previous value in a local variable instead.

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: ccfb431

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@xstate/svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ghost
Copy link

ghost commented Sep 15, 2022 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 15, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ccfb431:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@davidkpiano
Copy link
Member

Is this good to go?

@mittinatten
Copy link
Contributor Author

Is this good to go?

I assume the question wasn't directed at me, but as far as I'm concerned this is releasable. We've been using this version in production for a month or so without any issues, would be nice to not have to maintain a separate version.

@Andarist Andarist merged commit 44719c2 into statelyai:main Nov 14, 2022
@github-actions github-actions bot mentioned this pull request Nov 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andarist Andarist Andarist left review comments

@davidkpiano davidkpiano davidkpiano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mittinatten @davidkpiano @Andarist