Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the typegen in @xstate/svelte #3254

Merged
merged 4 commits into from
Apr 27, 2022
Merged

Conversation

Andarist
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2022

🦋 Changeset detected

Latest commit: 6869507

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@xstate/svelte Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ghost
Copy link

ghost commented Apr 27, 2022

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 27, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6869507:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

# Conflicts:
#	packages/xstate-svelte/src/fsm.ts
#	packages/xstate-svelte/src/useMachine.ts
@@ -75,5 +106,5 @@ export function useMachine<
}).unsubscribe;
});

return { state, send: service.send, service };
return { state, send: service.send, service } as any;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder why the typings are complaining here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably is just missing logic in TypeScript to "resolve" constraints of the conditional types in a generic context (or something like that). Although I've thought that there were some improvements in this area in the latest versions, perhaps they didn't cover a scenario like this

Minimal repro

@Andarist Andarist merged commit c0b787d into main Apr 27, 2022
@Andarist Andarist deleted the andarist/svelte-typegen branch April 27, 2022 21:12
@github-actions github-actions bot mentioned this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants