-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the typegen in @xstate/svelte
#3254
Conversation
🦋 Changeset detectedLatest commit: 6869507 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
9b674e1
to
d671bdd
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6869507:
|
# Conflicts: # packages/xstate-svelte/src/fsm.ts # packages/xstate-svelte/src/useMachine.ts
@@ -75,5 +106,5 @@ export function useMachine< | |||
}).unsubscribe; | |||
}); | |||
|
|||
return { state, send: service.send, service }; | |||
return { state, send: service.send, service } as any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder why the typings are complaining here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably is just missing logic in TypeScript to "resolve" constraints of the conditional types in a generic context (or something like that). Although I've thought that there were some improvements in this area in the latest versions, perhaps they didn't cover a scenario like this
No description provided.