Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESM build to @xstate/svelte package, fixes #2642 #3209

Merged
merged 3 commits into from
Apr 27, 2022

Conversation

schibrikov
Copy link

@schibrikov schibrikov commented Apr 8, 2022

I think adding rollup is unnecessary here, so I just added a second tsc config in order to generate ESM version.

fixes #2642

@changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2022

🦋 Changeset detected

Latest commit: 5a96214

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@xstate/svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ghost
Copy link

ghost commented Apr 8, 2022

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 8, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5a96214:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@schibrikov
Copy link
Author

Not sure if it should be a major/minor/patch bump, since nothing is changed. It has some impact on build pipelines preferring ESM packages though.

@Andarist Andarist merged commit 8520e20 into statelyai:main Apr 27, 2022
@github-actions github-actions bot mentioned this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@xstate/svelte] Missing ESM exports
2 participants