Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tie Svelte's useMachine's lifecycle to the lifecycle of the component #3172

Merged
merged 4 commits into from
Apr 27, 2022

Conversation

Andarist
Copy link
Member

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2022

🦋 Changeset detected

Latest commit: 4b11f87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@xstate/svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ghost
Copy link

ghost commented Mar 24, 2022

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 24, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4b11f87:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@Andarist Andarist marked this pull request as ready for review April 27, 2022 13:59
Copy link
Member

@davidkpiano davidkpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM; might want another review from someone experienced in Svelte though

@Andarist
Copy link
Member Author

I've already poked for a review on Discord and got a soft approval there 😅

@Andarist Andarist merged commit 390a115 into main Apr 27, 2022
@Andarist Andarist deleted the andarist/tweak-svelte-use-machine branch April 27, 2022 15:48
@github-actions github-actions bot mentioned this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants