Skip to content

Conversation

@lior-stark
Copy link
Contributor

@lior-stark lior-stark commented Jul 24, 2022

This change is Reviewable

@lior-stark lior-stark requested a review from ArielElp July 24, 2022 13:37
@lior-stark lior-stark self-assigned this Jul 24, 2022
* Add version, type, and contract_address_salt to deploy transaction
Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @lior-stark)


api/starknet_api_openrpc.json line 1258 at r1 (raw file):

                ]
            },
            "INVOKE_TXN_SPECIFIC_RECEIPT_PROPS": {

how about naming it INVOKE_TXN_RECEIPT_PROPERTIES?


api/starknet_api_openrpc.json line 1355 at r1 (raw file):

                    },
                    {
                        "$comment": "Used for deploy and declare transaction receipts",

I think it's easier to read if we're more explicit about it, i.e. have a PENDING_DEPLOY_TXN_RECEIPT/PENDING_DECLARE_TXN_RECEIPT types that are references to the common pending properties.

Copy link
Contributor Author

@lior-stark lior-stark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @ArielElp and @lior-stark)


api/starknet_api_openrpc.json line 1258 at r1 (raw file):

Previously, ArielElp wrote…

how about naming it INVOKE_TXN_RECEIPT_PROPERTIES?

Done.


api/starknet_api_openrpc.json line 1355 at r1 (raw file):

Previously, ArielElp wrote…

I think it's easier to read if we're more explicit about it, i.e. have a PENDING_DEPLOY_TXN_RECEIPT/PENDING_DECLARE_TXN_RECEIPT types that are references to the common pending properties.

yes, that was the initial version.
but it's really redundant, it's creating two objects that are structured exactly the same, and don't add anything to the schema.
note that I did add a comment here for future readers.

Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @lior-stark)

Copy link
Contributor Author

@lior-stark lior-stark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @lior-stark)

@lior-stark lior-stark merged commit 30e5baf into master Jul 25, 2022
@lior-stark lior-stark deleted the liors/pending-txn-receipt branch July 25, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants