-
Notifications
You must be signed in to change notification settings - Fork 87
add pending transaction receipt #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Add version, type, and contract_address_salt to deploy transaction
ArielElp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @lior-stark)
api/starknet_api_openrpc.json line 1258 at r1 (raw file):
] }, "INVOKE_TXN_SPECIFIC_RECEIPT_PROPS": {
how about naming it INVOKE_TXN_RECEIPT_PROPERTIES?
api/starknet_api_openrpc.json line 1355 at r1 (raw file):
}, { "$comment": "Used for deploy and declare transaction receipts",
I think it's easier to read if we're more explicit about it, i.e. have a PENDING_DEPLOY_TXN_RECEIPT/PENDING_DECLARE_TXN_RECEIPT types that are references to the common pending properties.
lior-stark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @ArielElp and @lior-stark)
api/starknet_api_openrpc.json line 1258 at r1 (raw file):
Previously, ArielElp wrote…
how about naming it INVOKE_TXN_RECEIPT_PROPERTIES?
Done.
api/starknet_api_openrpc.json line 1355 at r1 (raw file):
Previously, ArielElp wrote…
I think it's easier to read if we're more explicit about it, i.e. have a PENDING_DEPLOY_TXN_RECEIPT/PENDING_DECLARE_TXN_RECEIPT types that are references to the common pending properties.
yes, that was the initial version.
but it's really redundant, it's creating two objects that are structured exactly the same, and don't add anything to the schema.
note that I did add a comment here for future readers.
ArielElp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @lior-stark)
lior-stark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @lior-stark)
This change is