Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require JSX attributes and logical expressions to be indented correctly (react/jsx-indent) #1370

Closed
feross opened this issue Aug 15, 2019 · 1 comment
Closed

Require JSX attributes and logical expressions to be indented correctly (react/jsx-indent) #1370

feross opened this issue Aug 15, 2019 · 1 comment
Labels
accepted ecosystem impact enhancement

Comments

@feross
Copy link
Member

feross commented Aug 15, 2019 •
edited
Loading

https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-indent.md

We already have this rule enabled, but I want to add more options to the rule.

Before:

    "react/jsx-indent": ["error", 2],

After:

    "react/jsx-indent": ["error", 2, { "checkAttributes": true, "indentLogicalExpressions": true }],

This is now considered a warning (wasn't before):

    const Component = () => (
      <View
        ListFooterComponent={(
          <View
            rowSpan={3}
            placeholder="Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do"
          />
    )} // <--- note this is misaligned
      />
    );

Should be:

    const Component = () => (
      <View
        ListFooterComponent={(
          <View
            rowSpan={3}
            placeholder="Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do"
          />
        )}
      />
    );

This is now considered a warning (wasn't before):

<App>
  {condition && (
  <Hello />
  )}
</App>

Should be:

<App>
  {condition && (
    <Hello />
  )}
</App>
@feross
Copy link
Member Author

feross commented Aug 15, 2019

Might need to revert this if there's some cases I haven't thought of, but I'm going to ship it and wait for the complaints (if any). I want to get all these JSX rules out at the same time.

Shipping in standard 14.

@feross feross closed this as completed in ff4ef49 Aug 15, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2021
suchitg8 pushed a commit to suchitg8/standard that referenced this issue Apr 9, 2022
@feross
Require JSX attributes and logical expressions to be indented correct…
a8ec9d4 
…ly (react/jsx-indent)

Fixes: standard/standard#1370
kaiwang0119 added a commit to kaiwang0119/standard that referenced this issue Aug 26, 2024
@kaiwang0119
Require JSX attributes and logical expressions to be indented correct…
56ce1e9 
…ly (react/jsx-indent)

Fixes: standard/standard#1370
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted ecosystem impact enhancement
Projects
The Standard Project
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@feross