Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow self assignment of properties (no-self-assign) #1186

Closed
feross opened this issue Aug 28, 2018 · 1 comment
Closed

Disallow self assignment of properties (no-self-assign) #1186

feross opened this issue Aug 28, 2018 · 1 comment
Labels
enhancement
Milestone
standard 14

Comments

@feross
Copy link
Member

feross commented Aug 28, 2018

The no-self-assign rule is already enabled, however in ESLint 5 the default options object for the rule has changed from { props: false } to { props: true }.

I like this change, so let's keep it, assuming breakage isn't too high.

https://eslint.org/docs/rules/no-self-assign
@feross feross added this to the standard v12 milestone Aug 28, 2018
@feross feross mentioned this issue Aug 28, 2018
Closed
@feross feross modified the milestones: standard v12, standard v14 Jul 5, 2019
@feross feross closed this as completed in 757abf0 Jul 27, 2019
@feross
Copy link
Member Author

feross commented Jul 27, 2019

This rule was actually enabled in a prior upgrade of ESLint. I set the option explicitly nonetheless.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2021
suchitg8 pushed a commit to suchitg8/standard that referenced this issue Apr 9, 2022
@feross
Disallow self assignment of properties (no-self-assign)
72cd347 
This rule was actually enabled in a prior upgrade of ESLint. Let's set the option explicitly nonetheless.

Fixes: standard/standard#1186
kaiwang0119 added a commit to kaiwang0119/standard that referenced this issue Aug 26, 2024
@kaiwang0119
Disallow self assignment of properties (no-self-assign)
75249f7 
This rule was actually enabled in a prior upgrade of ESLint. Let's set the option explicitly nonetheless.

Fixes: standard/standard#1186
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
The Standard Project
Archived in project
Milestone
standard 14
Development

No branches or pull requests
1 participant
@feross