-
-
Notifications
You must be signed in to change notification settings - Fork 557
Add object-shorthand rule #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There's a problem with That rule is enabled in standard-with-typescript. And it should remain that way, for better type checking. So, the typescript config could possibly set object-shorthand back to |
|
@mightyiam I believe that that lint only applies to Also, I just realised that |
|
I've gone through and merged the PRs on the repos that I have access to! |
|
@LinusU Should we release this as a |
|
@voxpelli sounds very good 👍 |
01168be to
0e4d984
Compare
|
Rebased and switched to |
0e4d984 to
4623edc
Compare
voxpelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge away @LinusU 👍
|
🚀 |
Eco-system breakage:
semistandard- Use object shorthand semistandard#264tar-stream- Use object shorthand for properties mafintosh/tar-stream#118david- Use object shorthand for properties alanshaw/david#167subleveldown- Use object shorthand for properties Level/subleveldown#91simple-peer- Use object shorthand for properties feross/simple-peer#630bs58check- Use object shorthand for properties bitcoinjs/bs58check#25standard-format- Use object shorthand for properties max-mapper/standard-format#184multiaddr- Use object shorthand for properties multiformats/js-multiaddr#117standard-engine- Use object shorthand for properties standard-engine#219multihashing- Use object shorthand for properties multiformats/js-multihashing#49humanize-duration- Use object shorthand for properties EvanHahn/HumanizeDuration.js#170markdown-pdf- Use object shorthand for properties alanshaw/markdown-pdf#186fastparallelbittorrent-dht- Use object shorthand for properties webtorrent/bittorrent-dht#220simple-bin-help- Use object shorthand for properties bahmutov/simple-bin-help#84bittorrent-tracker- Use object shorthand for properties webtorrent/bittorrent-tracker#341rocha- Use object shorthand for properties bahmutov/rocha#140multihashes- chore: use object shorthand for properties multiformats/js-multihash#77mqemitter- Use object shorthand for properties mcollina/mqemitter#26reusify- Use object shorthand for properties mcollina/reusify#11weakmap-event- Use object shorthand for properties bendrucker/weakmap-event#9subcommand- Use object shorthand for properties max-mapper/subcommand#9chrome-net- Use object shorthand for properties feross/chrome-net#43ipld- Use object shorthand for properties ipld/js-ipld-dag-cbor#126fs-chunk-store- Use object shorthand for properties webtorrent/fs-chunk-store#15coininfo- Use object shorthand for properties cryptocoinjs/coininfo#97aerospike- Use object shorthand for properties aerospike/aerospike-client-nodejs#363ban-sensitive-files- Use object shorthand for properties bahmutov/ban-sensitive-files#53simple-websocket- Use object shorthand for properties feross/simple-websocket#63chrome-dgram- Use object shorthand for properties feross/chrome-dgram#19base-inputbip38sodium-signaturesglslify-bundle- Use object shorthand for properties glslify/glslify-bundle#9aedes-persistence- Use object shorthand for properties moscajs/aedes-persistence#58int-encoderosprey-router- Use object shorthand for properties mulesoft-labs/osprey-router#35geohubevp_bytestokeyurl-mappergl-blend-demotape-promise- Use object shorthand for properties jprichardson/tape-promise#21stackman- Use object shorthand for properties watson/stackman#11instant.iowebtorrent.iokarma-chrome-launcher- refactor: use object shorthand for properties karma-runner/karma-chrome-launcher#222eslint-plugin-standard- Use object shorthand for properties eslint-plugin-standard#34studynotes.orgbitmidi.comwebtorrent-desktop- Use object shorthand for properties webtorrent/webtorrent-desktop#1806levelupfront-mattermemdownleveldownassets-webpack-pluginpino- Use object shorthand for properties pinojs/pino#830testdoublefastify