-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rule no-void #135
Add rule no-void #135
Conversation
Avoid useless void operator
Sounds good to me, I don't really see when one would need it 🤔 |
This sounds good to me. Only one repo was failing and it was an easy fix: feross/chrome-net@8cc2520 Let's release this in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I was just recently contemplating whether there are useful usages of |
If I have to make an argument for button.onclick = () => void doSomething() However, you can do this with fewer characters like this: button.onclick = () => { doSomething() } And this avoids the need to understand a new concept. So it's clearer, IMO. Of course, you can always add an eslint ignore comment if you really need to use |
No argument here. |
I find void (() => { /* some iife */ })()
// vs
;(() => { /* another iife */ })() but this is kind of a style choice. |
I use |
Yep! So happy about this change! |
Avoid useless void operator