Remove redundant no-label-var rule #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-labels bans all labels, so it's not necessary to enable no-label-var (which lints how labels are used). Additionally, our settings for no-labels are equivalent to the defaults.
LinusU
approved these changes
Sep 29, 2018
|
Thanks for the PR! And good catch about the double warning.
In these situations, I'd rather be explicit since the defaults can change across ESLint versions and I'd rather we evolve the rules explicitly when we update ESLint instead of just getting a bag of changes. :) This will ship in standard v14 |
brettz9
pushed a commit
to brettz9/eslint-config-standard
that referenced
this pull request
Dec 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-labels bans all labels, so it's not necessary to enable no-label-var (which lints how labels are used). Additionally, our settings for no-labels are equivalent to the defaults.