Object watcher description #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Armaxis
approved these changes
Dec 3, 2019
| @@ -35,7 +35,7 @@ internal class AndroidXFragmentDestroyWatcher( | |||
| ) { | |||
| val view = fragment.view | |||
| if (view != null && configProvider().watchFragmentViews) { | |||
| objectWatcher.watch(view) | |||
| objectWatcher.watch(view, "Fragment received Fragment#onDestroyView() callback") | |||
There was a problem hiding this comment.
This one confused me too when I encountered a leak in our demo app. Might worth adding more info, e.g. "Fragment received Fragment#onDestroyView() callback: fragment instance is kept, but its view will be destroyed. All references to the view should be cleared to prevent leaks." Basically, something that tells people that fragment is staying around for a while, but the view is not.
There was a problem hiding this comment.
updated, and updated docs as well
|
With these changes the upgrade guide will need to be updated too, so that it doesn't override a deprecated method: |
pyricau
force-pushed
the
py/watch_description
branch
from
c47c777 to
f18c190
Compare
Originally KeyedWeakReference had a "name" field that wasn't used out of the box but could be useful to add identifying information. This PR renames it to "description" and uses it for automatic watching, surfacing more clearly why an object is watched. Related to #1656
pyricau
force-pushed
the
py/watch_description
branch
from
f18c190 to
23bd187
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally KeyedWeakReference had a "name" field that wasn't used out of the box but could be useful to add identifying information. This PR renames it to "description" and uses it for automatic watching, surfacing more clearly why an object is watched.
Related to #1656