Fix missing KSPropertySetter in member injection code gen
#899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While `KSClassDeclaration.getAllProperties()` covers our cases when we generate, I discovered an edge case when a class has _only_ `@set:Inject` properties. In this case, our KSP filter actually misses these because they come through as `KSPropertySetter`. This fixes that by checking for both it and `KSPropertyDeclaration`.
ZacSweers
changed the title
KSPropertySetter in member injection code gen
RBusarow
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
KSClassDeclaration.getAllProperties()covers our cases when we generate, I discovered an edge case when a class has only@set:Injectproperties. In this case, our KSP filter actually misses these because they come through asKSPropertySetter. This fixes that by checking for both it andKSPropertyDeclaration.