Skip to content

Conversation

@dfed
Copy link
Collaborator

@dfed dfed commented Apr 23, 2024

We seem to have access to a ton of machines. Let's use them.

@dfed dfed self-assigned this Apr 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dfed--watch-ci@c4c4cd6). Click here to learn what that means.

❗ Current head 4cb6667 differs from pull request most recent head 4d7736b. Consider uploading reports for the commit 4d7736b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             dfed--watch-ci     #312   +/-   ##
=================================================
  Coverage                  ?   82.76%           
=================================================
  Files                     ?       16           
  Lines                     ?      992           
  Branches                  ?        0           
=================================================
  Hits                      ?      821           
  Misses                    ?      171           
  Partials                  ?        0           

@dfed dfed marked this pull request as ready for review April 23, 2024 05:57
@dfed dfed merged commit 274b09e into dfed--watch-ci Apr 23, 2024
@dfed dfed deleted the dfed--more-machines branch April 23, 2024 15:25
dfed added a commit that referenced this pull request Apr 23, 2024
dfed added a commit that referenced this pull request Apr 23, 2024
dfed added a commit that referenced this pull request Apr 23, 2024
* Get watchOS tests running in CI

* Run the tests

* Parallelize (#312)

* Actually fail CI when tests fail (#313)

* Actually fail CI when tests fail

* Throw when we encounter errors

* Remove builds with Xcode that do not support Swift Concurrency

* Use appropriate Xcode for the job

* More tests require signed environments now

* Fix macOS 14 test sdk

* Use correct simulator name

* Do not embed watchOS

* Massage compiler

* Remove unnecessary Valet watchOS Test Host App.app

* New watch host target

* simpler

* stop testing watchOS_8

* Xcode 13 or later
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants