Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more README badges #291

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Add more README badges #291

merged 3 commits into from
Dec 14, 2022

Conversation

dfed
Copy link
Collaborator

@dfed dfed commented Dec 14, 2022

As title

@dfed dfed requested a review from NickEntin December 14, 2022 08:00
@dfed dfed marked this pull request as ready for review December 14, 2022 08:00
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2022 •
edited
Loading

Codecov Report

Merging #291 (84369cf) into master (27b513c) will not change coverage.
The diff coverage is n/a.

❗ Current head 84369cf differs from pull request most recent head cd412f0. Consider uploading reports for the commit cd412f0 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files          16       16           
  Lines         986      986           
=======================================
  Hits          856      856           
  Misses        130      130

NickEntin
NickEntin approved these changes Dec 14, 2022
View reviewed changes
Scripts/build.swift
@@ -60,7 +60,7 @@ enum Platform: String, CustomStringConvertible {
case .watchOS_7:
return "OS=7.2,name=Apple Watch Series 6 - 44mm"
case .watchOS_8:
return "OS=8.5,name=Apple Watch Series 6 - 44mm"
return "OS=8.5,name=Apple Watch Series 6 (44mm)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whyyyyyyy

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. I've had to make this change on multiple repos. Seems something changed on these CI machines recently 😬

@dfed dfed merged commit ca03dac into master Dec 14, 2022
@dfed dfed deleted the dfed--update-readme branch December 14, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickEntin NickEntin NickEntin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dfed @codecov-commenter @NickEntin