Skip to content

test(endtoend): Use Docker to start database servers #4076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 10 commits into from
Aug 25, 2025
Merged

test(endtoend): Use Docker to start database servers #4076

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c558997
test(endtoend): Use Docker to start database servers
kyleconroy Aug 25, 2025
0abcc96
Pull separately
kyleconroy Aug 25, 2025
768369f
sync.Do
kyleconroy Aug 25, 2025
a4893b1
Use the new Docker package
kyleconroy Aug 25, 2025
9bdaf61
Be paranoid about concurrency
kyleconroy Aug 25, 2025
f69c738
Test if things work on Windows and macOS
kyleconroy Aug 25, 2025
2c69f10
don't run tests on windows
kyleconroy Aug 25, 2025
153be0d
Only run tests on Linux
kyleconroy Aug 25, 2025
76bd585
Add a build workflow
kyleconroy Aug 25, 2025
5ded7d9
Split out build and test
kyleconroy Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
sync.Do
  • Loading branch information
@kyleconroy
kyleconroy committed Aug 25, 2025
commit 768369fd9f7db1fdcc4ca722157152b9c47e2262
89 changes: 55 additions & 34 deletions internal/sqltest/docker/mysql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,15 @@ import (
"database/sql"
"fmt"
"os/exec"
"sync"
"time"

_ "github.com/go-sql-driver/mysql"
)

var mysqlSync sync.Once
var mysqlHost string

func StartMySQLServer(c context.Context) (string, error) {
if err := Installed(); err != nil {
return "", err
Expand All @@ -22,46 +26,63 @@ func StartMySQLServer(c context.Context) (string, error) {
}
}

ctx, cancel := context.WithTimeout(c, 10*time.Second)
defer cancel()

cmd := exec.Command("docker", "run",
"--name", "sqlc_sqltest_docker_mysql",
"-e", "MYSQL_ROOT_PASSWORD=mysecretpassword",
"-e", "MYSQL_DATABASE=dinotest",
"-p", "3306:3306",
"-d",
"mysql:8",
)

output, err := cmd.CombinedOutput()
fmt.Println(string(output))
if err != nil {
return "", err
}
var syncErr error
mysqlSync.Do(func() {
ctx, cancel := context.WithTimeout(c, 10*time.Second)
defer cancel()

// Create a ticker that fires every 10ms
ticker := time.NewTicker(10 * time.Millisecond)
defer ticker.Stop()
cmd := exec.Command("docker", "run",
"--name", "sqlc_sqltest_docker_mysql",
"-e", "MYSQL_ROOT_PASSWORD=mysecretpassword",
"-e", "MYSQL_DATABASE=dinotest",
"-p", "3306:3306",
"-d",
"mysql:8",
)

uri := "root:mysecretpassword@/dinotest"
output, err := cmd.CombinedOutput()
fmt.Println(string(output))
if err != nil {
syncErr = err
return
}

db, err := sql.Open("mysql", uri)
if err != nil {
return "", fmt.Errorf("sql.Open: %w", err)
}
// Create a ticker that fires every 10ms
ticker := time.NewTicker(10 * time.Millisecond)
defer ticker.Stop()

uri := "root:mysecretpassword@/dinotest"

for {
select {
case <-ctx.Done():
return "", fmt.Errorf("timeout reached: %w", ctx.Err())
db, err := sql.Open("mysql", uri)
if err != nil {
syncErr = fmt.Errorf("sql.Open: %w", err)
return
}

case <-ticker.C:
// Run your function here
if err := db.PingContext(ctx); err != nil {
continue
for {
select {
case <-ctx.Done():
syncErr = fmt.Errorf("timeout reached: %w", ctx.Err())
return

case <-ticker.C:
// Run your function here
if err := db.PingContext(ctx); err != nil {
continue
}
mysqlHost = uri
return
}
return uri, nil
}
})

if syncErr != nil {
return "", syncErr
}

if mysqlHost == "" {
return "", fmt.Errorf("mysql server setup failed")
}

return mysqlHost, nil
}
90 changes: 55 additions & 35 deletions internal/sqltest/docker/postgres.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,15 @@ import (
"fmt"
"log/slog"
"os/exec"
"sync"
"time"

"github.com/jackc/pgx/v5"
)

var postgresSync sync.Once
var postgresHost string

func StartPostgreSQLServer(c context.Context) (string, error) {
if err := Installed(); err != nil {
return "", err
Expand All @@ -22,48 +26,64 @@ func StartPostgreSQLServer(c context.Context) (string, error) {
}
}

ctx, cancel := context.WithTimeout(c, 5*time.Second)
defer cancel()
var syncErr error
postgresSync.Do(func() {
ctx, cancel := context.WithTimeout(c, 5*time.Second)
defer cancel()

cmd := exec.Command("docker", "run",
"--name", "sqlc_sqltest_docker_postgres",
"-e", "POSTGRES_PASSWORD=mysecretpassword",
"-e", "POSTGRES_USER=postgres",
"-p", "5432:5432",
"-d",
"postgres:16",
"-c", "max_connections=200",
)
cmd := exec.Command("docker", "run",
"--name", "sqlc_sqltest_docker_postgres",
"-e", "POSTGRES_PASSWORD=mysecretpassword",
"-e", "POSTGRES_USER=postgres",
"-p", "5432:5432",
"-d",
"postgres:16",
"-c", "max_connections=200",
)

output, err := cmd.CombinedOutput()
fmt.Println(string(output))
if err != nil {
return "", err
}
output, err := cmd.CombinedOutput()
fmt.Println(string(output))
if err != nil {
syncErr = err
return
}

// Create a ticker that fires every 10ms
ticker := time.NewTicker(10 * time.Millisecond)
defer ticker.Stop()
// Create a ticker that fires every 10ms
ticker := time.NewTicker(10 * time.Millisecond)
defer ticker.Stop()

uri := "postgres://postgres:mysecretpassword@localhost:5432/postgres?sslmode=disable"
uri := "postgres://postgres:mysecretpassword@localhost:5432/postgres?sslmode=disable"

for {
select {
case <-ctx.Done():
return "", fmt.Errorf("timeout reached: %w", ctx.Err())
for {
select {
case <-ctx.Done():
syncErr = fmt.Errorf("timeout reached: %w", ctx.Err())
return

case <-ticker.C:
// Run your function here
conn, err := pgx.Connect(ctx, uri)
if err != nil {
slog.Debug("sqltest", "connect", err)
continue
case <-ticker.C:
// Run your function here
conn, err := pgx.Connect(ctx, uri)
if err != nil {
slog.Debug("sqltest", "connect", err)
continue
}
if err := conn.Ping(ctx); err != nil {
slog.Error("sqltest", "ping", err)
continue
}
postgresHost = uri
return
}
if err := conn.Ping(ctx); err != nil {
slog.Error("sqltest", "ping", err)
continue
}
return uri, nil
}
})

if syncErr != nil {
return "", syncErr
}

if postgresHost == "" {
return "", fmt.Errorf("postgres server setup failed")
}

return postgresHost, nil
}
Loading