Skip to content

fix: range subselect alias pointer dereference #3711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 4 commits into from
Aug 6, 2025
Merged

fix: range subselect alias pointer dereference #3711

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3219da3
fix: range subselect alias pointer dereference
ahme-dev Nov 16, 2024
eaa8b67
add endtoend tests
andrewmbenton Aug 5, 2025
8e48e5d
rebase onto main and update test gens
andrewmbenton Aug 5, 2025
26f96d5
add back devenv.lock
andrewmbenton Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: range subselect alias pointer dereference
  • Loading branch information
@ahme-dev @andrewmbenton
ahme-dev authored and andrewmbenton committed Aug 5, 2025
commit 3219da3f9ed365501306ce46ab3c6e8a7a683dc4
8 changes: 7 additions & 1 deletion internal/compiler/output_columns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,9 +596,15 @@ func (c *Compiler) sourceTables(qc *QueryCatalog, node ast.Node) ([]*Table, erro
if err != nil {
return nil, err
}

var tableName string
if n.Alias != nil {
tableName = *n.Alias.Aliasname
}

tables = append(tables, &Table{
Rel: &ast.TableName{
Name: *n.Alias.Aliasname,
Name: tableName,
},
Columns: cols,
})
Expand Down