Skip to content

fix (engine/sqlite): normalize table names (#3162) #3657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 2 commits into from
Nov 25, 2024
Merged

fix (engine/sqlite): normalize table names (#3162) #3657

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeddc66
fix (engine/sqlite): normalize table names (#3162)
jvns Oct 16, 2024
186bce6
Test table name normalization
jvns Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix (engine/sqlite): normalize table names (#3162) 
fixes #3162
  • Loading branch information
@jvns @kyleconroy
jvns authored and kyleconroy committed Nov 25, 2024
commit aeddc6662df5c481d37305f75f38702d0b580edb
6 changes: 3 additions & 3 deletions internal/engine/sqlite/convert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ type Delete_stmt interface {
func (c *cc) convertDelete_stmtContext(n Delete_stmt) ast.Node {
if qualifiedName, ok := n.Qualified_table_name().(*parser.Qualified_table_nameContext); ok {

tableName := qualifiedName.Table_name().GetText()
tableName := identifier(qualifiedName.Table_name().GetText())
relation := &ast.RangeVar{
Relname: &tableName,
}
Expand Down Expand Up @@ -854,7 +854,7 @@ func (c *cc) convertReturning_caluseContext(n parser.IReturning_clauseContext) *
}

func (c *cc) convertInsert_stmtContext(n *parser.Insert_stmtContext) ast.Node {
tableName := n.Table_name().GetText()
tableName := identifier(n.Table_name().GetText())
rel := &ast.RangeVar{
Relname: &tableName,
}
Expand Down Expand Up @@ -936,7 +936,7 @@ func (c *cc) convertTablesOrSubquery(n []parser.ITable_or_subqueryContext) []ast
}

if from.Table_name() != nil {
rel := from.Table_name().GetText()
rel := identifier(from.Table_name().GetText())
rv := &ast.RangeVar{
Relname: &rel,
Location: from.GetStart().GetStart(),
Expand Down
2 changes: 1 addition & 1 deletion internal/engine/sqlite/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ type tableNamer interface {

func parseTableName(c tableNamer) *ast.TableName {
name := ast.TableName{
Name: c.Table_name().GetText(),
Name: identifier(c.Table_name().GetText()),
}
if c.Schema_name() != nil {
name.Schema = c.Schema_name().GetText()
Expand Down