Skip to content

Fix incorrect generate model names for "metadata" suffix #3553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 3 commits into from
Nov 25, 2024
Merged

Fix incorrect generate model names for "metadata" suffix #3553

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3c2a8c
fix incorrect generate model names for "bonuses" and "metadata"
qanghaa Aug 18, 2024
3f67f73
remove bonuses to special table name list
qanghaa Oct 19, 2024
17fea60
remove bonuses to special table name list
qanghaa Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove bonuses to special table name list
  • Loading branch information
@qanghaa @kyleconroy
qanghaa authored and kyleconroy committed Nov 25, 2024
commit 17fea6024706af5bdb8a9ea7eb5ab15a60a8cfeb
4 changes: 0 additions & 4 deletions internal/endtoend/testdata/inflection/mysql/go/models.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 0 additions & 27 deletions internal/endtoend/testdata/inflection/mysql/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions internal/endtoend/testdata/inflection/mysql/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,4 @@ SELECT * FROM product_meta;
SELECT * FROM calories;

/* name: GetProductMetadata :many */
SELECT * FROM product_metadata;

/* name: GetBonuses :many */
SELECT * FROM bonuses;
SELECT * FROM product_metadata;
2 changes: 0 additions & 2 deletions internal/endtoend/testdata/inflection/mysql/schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,3 @@ CREATE TABLE students (id text not null);
CREATE TABLE product_meta (id text not null);
CREATE TABLE calories (id text not null);
CREATE TABLE product_metadata (id text not null);
CREATE TABLE bonuses (id text not null);

4 changes: 0 additions & 4 deletions internal/endtoend/testdata/inflection/postgresql/pgx/v4/go/models.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 0 additions & 24 deletions internal/endtoend/testdata/inflection/postgresql/pgx/v4/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions internal/endtoend/testdata/inflection/postgresql/pgx/v4/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,4 @@ SELECT * FROM product_meta;
SELECT * FROM calories;

-- name: GetProductMetadata :many
SELECT * FROM product_metadata;

-- name: GetBonuses :many
SELECT * FROM bonuses;
SELECT * FROM product_metadata;
3 changes: 1 addition & 2 deletions internal/endtoend/testdata/inflection/postgresql/pgx/v4/schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,4 @@ CREATE TABLE campus (id text not null);
CREATE TABLE students (id text not null);
CREATE TABLE product_meta (id text not null);
CREATE TABLE calories (id text not null);
CREATE TABLE product_metadata (id text not null);
CREATE TABLE bonuses (id text not null);
CREATE TABLE product_metadata (id text not null);
4 changes: 0 additions & 4 deletions internal/endtoend/testdata/inflection/postgresql/pgx/v5/go/models.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 0 additions & 24 deletions internal/endtoend/testdata/inflection/postgresql/pgx/v5/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions internal/endtoend/testdata/inflection/postgresql/pgx/v5/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,4 @@ SELECT * FROM product_meta;
SELECT * FROM calories;

-- name: GetProductMetadata :many
SELECT * FROM product_metadata;

-- name: GetBonuses :many
SELECT * FROM bonuses;
SELECT * FROM product_metadata;
3 changes: 1 addition & 2 deletions internal/endtoend/testdata/inflection/postgresql/pgx/v5/schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,4 @@ CREATE TABLE campus (id text not null);
CREATE TABLE students (id text not null);
CREATE TABLE product_meta (id text not null);
CREATE TABLE calories (id text not null);
CREATE TABLE product_metadata (id text not null);
CREATE TABLE bonuses (id text not null);
CREATE TABLE product_metadata (id text not null);
4 changes: 0 additions & 4 deletions internal/endtoend/testdata/inflection/postgresql/stdlib/go/models.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 0 additions & 27 deletions internal/endtoend/testdata/inflection/postgresql/stdlib/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions internal/endtoend/testdata/inflection/postgresql/stdlib/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,4 @@ SELECT * FROM product_meta;
SELECT * FROM calories;

-- name: GetProductMetadata :many
SELECT * FROM product_metadata;

-- name: GetBonuses :many
SELECT * FROM bonuses;
SELECT * FROM product_metadata;
3 changes: 1 addition & 2 deletions internal/endtoend/testdata/inflection/postgresql/stdlib/schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,4 @@ CREATE TABLE campus (id text not null);
CREATE TABLE students (id text not null);
CREATE TABLE product_meta (id text not null);
CREATE TABLE calories (id text not null);
CREATE TABLE product_metadata (id text not null);
CREATE TABLE bonuses (id text not null);
CREATE TABLE product_metadata (id text not null);
4 changes: 0 additions & 4 deletions internal/inflection/singular.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@ func Singular(s SingularParams) string {
return "wave"
}

if strings.ToLower(s.Name) == "bonuses" {
return "bonus"
}

if strings.ToLower(s.Name) == "metadata" {
return "metadata"
}
Expand Down
Loading