Skip to content

feat(analyzer): Automatically create databases #3376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kyleconroy wants to merge 5 commits into from
Closed

feat(analyzer): Automatically create databases #3376

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0a485dd
It's all broken
kyleconroy May 8, 2024
2ee6b81
WIP
kyleconroy May 10, 2024
47867c5
Add database: auto
kyleconroy May 10, 2024
fda2e45
Try and use auto for tests
kyleconroy May 10, 2024
c56000d
Fix tests
kyleconroy May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix tests
  • Loading branch information
@kyleconroy
kyleconroy committed May 10, 2024
commit c56000d41f0cbf1aa0b5658f25014b3ba8ada699
1 change: 1 addition & 0 deletions internal/config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ func TestInvalidConfig(t *testing.T) {
Database: &Database{
URI: "",
Managed: false,
Auto: false,
},
}},
})
Expand Down
2 changes: 1 addition & 1 deletion internal/config/validate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ func Validate(c *Config) error {
for _, sql := range c.SQL {
if sql.Database != nil {
switch {
case sql.Database.URI == "":
case sql.Database.URI != "":
case sql.Database.Managed:
case sql.Database.Auto:
default:
Expand Down