fix(compiler): Skip analysis of queries without a name annotation
#3072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update tests to work with new behavior
kyleconroy
approved these changes
Dec 20, 2023
alfonsodev
pushed a commit
to ExponentiaTeam/sqlc
that referenced
this pull request
Oct 13, 2025
…qlc-dev#3072) * fix(compiler): Skip analysis of queries without a `name` annotation Also update tests to work with new behavior * Only run builtins test in base context for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our codegen plugins don't produce output for queries that don't have an annotation like
-- name: Foo :one, but sqlc still does a full query analysis. This change aborts the analysis for any query without an annotation.The actual change is small, but a fair amount of test output had to be updated.